[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 12 11:58:32 PST 2021


vitalybuka added inline comments.


================
Comment at: clang/include/clang/Basic/SanitizerBlacklist.h:20
 #include <memory>
 #include <vector>
 
----------------
This file should go into a separate patch. It touches multiple files with simple changes but unlikely will case rollback.
It's unrelated to most critical change in Options.td which may need some discussion.
Options.td so I am ready accept such changes here changes ASAP.


================
Comment at: clang/include/clang/Basic/SanitizerBlacklist.h:28
 
-class SanitizerBlacklist {
+class SanitizerBlocklist {
   std::unique_ptr<SanitizerSpecialCaseList> SSCL;
----------------
NoSanitizeList ?


================
Comment at: clang/include/clang/Basic/SanitizerBlacklist.h:36
+  ~SanitizerBlocklist();
+  bool isBlocklistedGlobal(SanitizerMask Mask, StringRef GlobalName,
                            StringRef Category = StringRef()) const;
----------------
containsGlobal
containsType




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96203/new/

https://reviews.llvm.org/D96203



More information about the cfe-commits mailing list