[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 12 11:55:50 PST 2021


jyknight added a comment.

> I ended up reverting the changes I made to llvm/lib/IR/AutoUpgrade.cpp as the file was including llvm/Analysis/ObjCARCUtil.h, which was violating layering.

It looks like it was not actually reverted in the version ultimately submitted. I've pushed commit 3c06676de14d7dd6dc3d1bf2989c503a2a5d438a <https://reviews.llvm.org/rG3c06676de14d7dd6dc3d1bf2989c503a2a5d438a> which reverts the change to llvm/lib/IR/AutoUpgrade.cpp (duplicating the string constant).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92808/new/

https://reviews.llvm.org/D92808



More information about the cfe-commits mailing list