[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 12 10:37:33 PST 2021


njames93 added a comment.

I'm not an objc guy, but can you add a test case demonstrating class(?) methods showing as `+name:`?



================
Comment at: clang-tools-extra/clangd/AST.cpp:224-226
+  if (const ObjCContainerDecl *C = dyn_cast<ObjCContainerDecl>(&ND))
+    return printObjCContainer(*C);
+  if (const ObjCMethodDecl *Method = dyn_cast<ObjCMethodDecl>(&ND)) {
----------------
nit: Can make these `const auto *` as the type is spelt in the initialisation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96612/new/

https://reviews.llvm.org/D96612



More information about the cfe-commits mailing list