[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 12 10:12:26 PST 2021


Anastasia added a comment.

In D96515#2560280 <https://reviews.llvm.org/D96515#2560280>, @Anastasia wrote:

> In D96515#2559424 <https://reviews.llvm.org/D96515#2559424>, @svenvh wrote:
>
>> It probably makes sense to update `clang/docs/UsersManual.rst` as part of this change.  In particular the following sentence is no longer true after this patch: "By default the OpenCL headers are not loaded and therefore certain builtin types and most of builtin functions are not declared."
>
> Yes, that's right but I think there is a bigger change that needs to be made i.e. I would completely remove `-finclude-default-header` and let it live on OpenCLSupport page. I would prefer a separate review for docs though.

FYI here is the review for the docs update: https://reviews.llvm.org/D96616


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96515/new/

https://reviews.llvm.org/D96515



More information about the cfe-commits mailing list