[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added inline comments.


================
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27
+  // expected-error at -3 0+{{no matching function for call to 'barrier'}}
+  // expected-error@* {{typedef type cl_mem_fence_flags not found; include the base header with -finclude-default-header}}
+}
----------------
Actually, could we remove the `typedef` from the diagnostic because it exposes the implementation details unnecessarily? I believe the spec doesn't say what the type is aside from enums?  As a matter of fact, we have some types implemented as typedefs that should have been a native types e.g. vector types that we might change one day.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96051/new/

https://reviews.llvm.org/D96051