[PATCH] D96139: [clang-tidy] Simplify inaccurate erase check

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 12 08:24:20 PST 2021


njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.

LG with nit.



================
Comment at: clang-tools-extra/clang-tidy/bugprone/InaccurateEraseCheck.cpp:25-27
+              1, anyOf(cxxMemberCallExpr(callee(cxxMethodDecl(hasName("end"))))
+                           .bind("end"),
+                       anything())))
----------------
This seems like a use case for the optionally matcher.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96139/new/

https://reviews.llvm.org/D96139



More information about the cfe-commits mailing list