[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added a comment.

Btw, could you clang-format your patch? I normally use `git -lang-format HEAD~`. Thank you!



================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:261
+           diags.getCustomDiagID(clang::DiagnosticsEngine::Error,
+             "Use of `-fdefault-double-8` requires `-fdefault-real-8`");
+           diags.Report(diagID);
----------------
arnamoy10 wrote:
> awarzynski wrote:
> > Is this requirement document anywhere?
> Just found out through running `gfortran`
Oh, indeed:
```
gfortran -fdefault-double-8 file.f
f951: Fatal Error: Use of ‘-fdefault-double-8’ requires ‘-fdefault-real-8’
compilation terminated.
```
Thanks you for being so thorough and checking this! :)

I think that it would help to:
* add a comment explaining _why_ this diagnostic is added (compatibility with `gfortran` is a good reason IMO)
*  add a test to verify that it's indeed issued.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96344/new/

https://reviews.llvm.org/D96344