[PATCH] D96578: [clangd] Remove the cross-file-rename option.

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:405
+    // prepareRename is latency-sensitive: we deliberately pass a nullptr index
+    // to save the cost, thus the result may be incomplete as it only contains
+    // main-file occurrences.
----------------
i'd trim this down a bit now: "we don't query the index, as we only need main-file references"


================
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:237
-    IsMainFileOnly = false;
-  // If the symbol is not indexable, we disallow rename.
-  if (!SymbolCollector::shouldCollectSymbol(
----------------
I don't understand why we're now allowing rename of non-indexable symbols.
Is this really intended? At the least it seems like an unrelated change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96578/new/

https://reviews.llvm.org/D96578