[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook
Arthur Eubanks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 11 18:39:40 PST 2021
aeubanks added inline comments.
================
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071
+ // ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink.
+ // For -O0 ThinLTO PreLink does basic optimization and triggers
+ // OptimizerLastEPCallbacks. PostLink will not
+ // run optimizations and this callback should
----------------
We could fix this. It doesn't make sense for only -O0 to run OptimizerLastEPCallbacks prelink. Would that help simplify this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96456/new/
https://reviews.llvm.org/D96456
More information about the cfe-commits
mailing list