[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

Thu Feb 11 12:00:14 PST 2021

ahatanak added a comment.

In D92808#2557132 <https://reviews.llvm.org/D92808#2557132>, @fhahn wrote:

> Another thing I noticed that there's verifier support missing. I think we should at least check that only a single `clang.arc.rv` bundle is specified (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Verifier.cpp#L3191). We should probably also enforce that the bundle is only provided for functions with an `i8*` return type. That can also be done after the main patch lands.

I added the checks to the verifier. Note that the verifier accepts calls returning any pointer type since the return type isn't always `i8*` (e.g., `NSObject *foo(void)`).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92808/new/

https://reviews.llvm.org/D92808