[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

[Haojian Wu via Phabricator via cfe-commits]

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

maybe add some data (improvement DecisionForest vs heuristic) in the patch description.



================
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651
+  auto Results =
+      completions("int main() { abs^ }", {func("absl"), func("absb")});
   EXPECT_THAT(Results.Completions,
----------------
usaxena95 wrote:
> hokein wrote:
> > sorry, I didn't infer the motivation of this change func->ns from this patch, could you explain?
> Sorry about not highlighting this.
> The ML model doesn't rank the function before the namespace. I removed this and made both of these as functions to independently validate the effect of references.
ah, I see, that makes sense, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96353/new/

https://reviews.llvm.org/D96353