[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 10 23:44:46 PST 2021
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
thanks! this looks like a nice improvement!
================
Comment at: clang/test/CodeCompletion/member-access.cpp:88
+ TemplateClass<S, T> &relatedField;
+ BaseTemplate<S> &relatedFunction();
+
----------------
hmm, inserting new code here will shift all offsets of below code, I would append a new test in this file to keep a clearer history. but up to you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96376/new/
https://reviews.llvm.org/D96376
More information about the cfe-commits
mailing list