[PATCH] D96320: [ThinLTO, Sanitizers] Skip instrumentation by testing backend

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 10:00:35 PST 2021


aeubanks added a comment.

This seems like the wrong fix to me.
ThinLTO only runs the simplification pipeline pre-link, then runs it again plus the optimization pipeline. The optimization pipeline is the only place that OptimizerLastEPCallback should run (aside from the -O0 pipeline). Basically, the OptimizerLastEPCallbacks should only ever run once throughout all of compilation for a given module.

So it seems like LTO should do the same and only run the simplification pipeline pre-link, rather than just forward to `buildPerModuleDefaultPipeline()`, which runs both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96320/new/

https://reviews.llvm.org/D96320



More information about the cfe-commits mailing list