[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added a comment.

In D96178#2551449 <https://reviews.llvm.org/D96178#2551449>, @Anastasia wrote:

> @svenvh We haven't looked into address spaces in details when adding this. I wonder what behavior would make sense for new/delete? Do we plan to allow new/delete in named address spaces or only in generic? It might be more helpful to allow named address spaces since generic has not been intended for allocations, but however generic makes things easier because it avoids duplication and the concrete address space can always be cast to it. I think `constant` doesn't make sense at all since nothing can be done with a readonly chunk of memory?

It seems the use of new/delete still needs a more thorough investigation indeed. I'd suggest we don't try to solve that in this patch (nor hold this back), so a PR sounds like a good option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96178/new/

https://reviews.llvm.org/D96178