[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 08:36:00 PST 2021


jdoerfert added inline comments.


================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:147
+    No = 2,   // No loop is assumed to be finite.
+  };
+
----------------
Can we have different names?

`FiniteLoopsKind::None` sounds more like what ``FiniteLoopsKind::No` implies.

Maybe:
```
enum class FiniteLoopAssumptionKind {
LANGUAGE,
ALWAYS
NEVER,
};
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96419/new/

https://reviews.llvm.org/D96419



More information about the cfe-commits mailing list