[PATCH] D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+.

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 08:31:53 PST 2021


jdoerfert added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.h:523
     return getLangOpts().C11 || getLangOpts().C17 || getLangOpts().C2x;
   }
 
----------------
Can you modify the documentation to talk about what loops must make progress, this is the code below transcribed. 

Also, I don't see how this works. Should the const-ness of the condition not be related to the standard/language to make a decision?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96418/new/

https://reviews.llvm.org/D96418



More information about the cfe-commits mailing list