[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

Wed Feb 10 08:24:32 PST 2021

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D93630#2506604 <https://reviews.llvm.org/D93630#2506604>, @aaron.ballman wrote:

> In D93630#2504758 <https://reviews.llvm.org/D93630#2504758>, @vsavchenko wrote:
>
>> I'll clean up the tests!  But, unfortunately, I couldn't proceed with GCC folks.  I asked around and I'm not allowed to do that (company rules).
>
> Ah, that's unfortunate. When I get the chance, I'll try to send an email to the GCC lists. Do you mind if I pass the email by you first (privately) to ensure I'm not misstating your goals or anything from your patch?

I sent the email to the GCC lists (https://gcc.gnu.org/pipermail/gcc/2021-January/234747.html) and there were no follow-up responses after two weeks. I take the silence to mean there are no concerns from the GCC side of things, so this patch (finally!) LGTM. Thank you for sticking through the long process on this one!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93630/new/

https://reviews.llvm.org/D93630