[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Jakub Budiský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 05:40:45 PST 2021


Budovi added a comment.

In D94661#2553843 <https://reviews.llvm.org/D94661#2553843>, @curdeius wrote:

> LGTM. But let other folks a few days to chime in. Especially @mydeveloperday's input would be valuable here as he already attempted to implement this.

Sure, no problem. Thanks for your input once again :), really appreciate it.

In D94661#2553843 <https://reviews.llvm.org/D94661#2553843>, @curdeius wrote:

> Do you have have commit rights or you need somebody to land this for you? If it's the latter, please provide "Firstname Name <mail at domain>" for the commit attribution or we will just use the one associated with your Phabricator user.

I don't have commit rights (this is my first contribution… well an attempt anyway) but the Phabricator user settings, i.e. something along `Jakub Budiský <jakub.budisky at gmail.com>`, should be fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94661/new/

https://reviews.llvm.org/D94661



More information about the cfe-commits mailing list