[PATCH] D95753: Store compilation dir separately in coverage mapping

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 10 00:48:24 PST 2021


phosek added a comment.

In D95753#2534895 <https://reviews.llvm.org/D95753#2534895>, @vsk wrote:

> Thanks for pointing DW_AT_comp_dir out. For coverage, gating the use of relative paths on a flag sounds reasonable to me. It should also be possible to extend the .covmapping format to include something like DW_AT_comp_dir: compared to adding a flag, this would take a lot more work.

I've implemented what's effectively an equivalent of `DW_AT_comp_dir` by storing the current directory as the first entry in coverage mapping filenames as discussed over email, let me know if this makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95753/new/

https://reviews.llvm.org/D95753



More information about the cfe-commits mailing list