[PATCH] D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 9 19:44:15 PST 2021


Szelethus added inline comments.


================
Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:105
+  using MacroExpansionText = SmallString<40>;
+  using ExpansionMap = llvm::DenseMap<SourceLocation, MacroExpansionText>;
+  using ExpansionRangeMap = llvm::DenseMap<SourceLocation, SourceLocation>;
----------------
Hmm, I'm by no means an expert, but isn't a string-like structure a bit big for a `DenseMap`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93222/new/

https://reviews.llvm.org/D93222



More information about the cfe-commits mailing list