[PATCH] D96376: [CodeComplete] Member completion: heuristically resolve some dependent base exprs

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 9 15:11:50 PST 2021


sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: usaxena95, kadircet, arphaman.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Today, inside a template, you can get completion for:

Foo<T> t;
t.^

t has dependent type Foo<T>, and we use the primary template to find its members.
However we also want this to work:

t.foo.bar().^

The type of t.foo.bar() is DependentTy, so we attempt to resolve using similar
heuristics (e.g. primary template).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96376

Files:
  clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
  clang/lib/Sema/SemaCodeComplete.cpp
  clang/test/CodeCompletion/member-access.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96376.322519.patch
Type: text/x-patch
Size: 14498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210209/61ea1479/attachment-0001.bin>


More information about the cfe-commits mailing list