[PATCH] D96274: [clang][cli] Generate and round-trip Diagnostic options

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 9 06:29:21 PST 2021


probinson added a comment.

I don't claim to be very familiar with this area but "round-trip" and "test" would make me think those bits should be in a lit test or unittest. As it is, it's not obvious what is functional and what is testing here.
Possibly I am misunderstanding something fundamental about how these options work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96274/new/

https://reviews.llvm.org/D96274



More information about the cfe-commits mailing list