[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 9 00:39:23 PST 2021


curdeius added a comment.

It's getting into a good shape. Please fix the nits.



================
Comment at: clang/unittests/Format/FormatTest.cpp:19059
+  // Members are *two* levels below the record;
+  // Style.IndentWidth == 2, thus yielding a 4 spaces wide indentation
+  verifyFormat("class C {\n"
----------------
Nit: please put full stops at the end of comments. Here and elsewhere.


================
Comment at: clang/unittests/Format/FormatTest.cpp:19097
+  // Test with a different indentation width;
+  // also proves that the result is Style.AccessModifierOffset agonistic
+  Style.IndentWidth = 3;
----------------
Typo: agnostic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94661/new/

https://reviews.llvm.org/D94661



More information about the cfe-commits mailing list