[PATCH] D96315: [X86][AMX] Assemble new AMX interface to an experiment header file.

[Pengfei Wang via Phabricator via cfe-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/amxintrin_experiment.h:12
+ * This file is experiment interface for AMX new programming model.
+ */
+
----------------
It's better to add such macros:
```
#ifndef __AMXINTRIN_EXPERIMENT_H
#define __AMXINTRIN_EXPERIMENT_H
#ifdef __x86_64__
```


================
Comment at: clang/test/CodeGen/X86/amx_api.c:4
 
-#include <immintrin.h>
+#include <amxintrin_experiment.h>
 
----------------
Better to add `#include <immintrin.h>` at the same time. Or to simplify, add it in `amxintrin_experiment.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96315/new/

https://reviews.llvm.org/D96315