[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

[Conrad Poelman via Phabricator via cfe-commits]

poelmanc added a comment.

In D68682#2547906 <https://reviews.llvm.org/D68682#2547906>, @kadircet wrote:

> It looks like premerge tests skipped your last diff with id 321451 (https://reviews.llvm.org/harbormaster/?after=87950). You can re-trigger by uploading a new diff, in the meantime i would also file a bug to https://github.com/google/llvm-premerge-checks/issues. mentioning your diff id.

Thanks @kadircet, actually just reviewing the current bug list explained the problem: https://github.com/google/llvm-premerge-checks/issues/263, //Build is not triggered if diff repository is not set//. I wasn't selecting //rG <https://reviews.llvm.org/source/llvm-github/> LLVM Github Monorepo// per instructions at https://llvm.org/docs/Phabricator.html that said //Leave the Repository field blank//.

HarborMaster has now run and passes all tests on Windows and Linux.

1. clang-format for a new test case in `clang-tools-extra/test/clang-tidy/checkers/readability-redundant-member-init.cpp`. That test case formatting matches real-world examples so I'm reluctant to change it - I believe it's clang-formatted but with different settings from llvm-project's.
2. clang-tidy finds 8 `int` vs `size_t` comparisons. While `int` feels safer when subtraction is involved (since one can `assert` variables stay positive), this particular code would work fine with `int` variables changed to `size_t`, or alternatively with `static_cast` to silence the warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68682/new/

https://reviews.llvm.org/D68682