[PATCH] D96196: [Sema][NFC] Create Sema::BuildImplicitCast

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 8 18:29:56 PST 2021


shafik added inline comments.


================
Comment at: clang/lib/Sema/SemaCast.cpp:1060
   if (tcr != TC_Success && msg != 0) {
     if (SrcExpr.isInvalid()) // if conversion failed, don't report another error
       return;
----------------
Can we ever have this case w/ the added `if (SrcExpr.isInvalid())` above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96196/new/

https://reviews.llvm.org/D96196



More information about the cfe-commits mailing list