[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

Thank you for this patch @FarisRehman , it's great to see more tests being ported to the new driver!

Although this patches touches many files, it mostly just generalizes the `RUN` lines. With this change we can easily switch between `f18` and `flang-new` (depending on `FLANG_BUILD_NEW_DRIVER`), which is very helpful!

LGTM (could you moving `options::OPT_fopenmp, options::OPT_fopenacc` do a dedicated method before merging?)



================
Comment at: clang/include/clang/Driver/Options.td:4219-4220
 def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">, Group<f_Group>, Alias<ffixed_line_length_EQ>;
+def fopenacc : Flag<["-"], "fopenacc">, Group<f_Group>,
+  HelpText<"Parse OpenACC pragmas and generate parallel code.">;
 
----------------
Could we follow `gcc` here:
```
gcc --help=fortran | grep openacc
  -fopenacc                   Enable OpenACC.
```


================
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:25-26
   Args.AddAllArgs(CmdArgs, {options::OPT_ffixed_form, options::OPT_ffree_form,
-                            options::OPT_ffixed_line_length_EQ});
+                            options::OPT_ffixed_line_length_EQ,
+                            +options::OPT_fopenmp, options::OPT_fopenacc});
 }
----------------
`-fopenmp` and `-fopenacc` enable extensions, so they are not dialect options.


================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:350
+
+  // Add predefinitions based on language features enabled
+  if (frontendOptions.features_.IsEnabled(
----------------
[nit] `language` -> `extensions`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96032/new/

https://reviews.llvm.org/D96032