[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 8 08:58:36 PST 2021


njames93 added a comment.

I'm unable to cleanly apply this patch, looks like something was a bit off when you created the diff.

  ➜  llvm-project git:(main) ✗ arc patch D95714                           
   INFO  Base commit is not in local repository; trying to fetch.
  Created and checked out branch arcpatch-D95714.
  Checking patch dev/null => clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-cxx20.cpp...
  error: dev/null: does not exist in index
  Checking patch clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp...
  Applied patch clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp cleanly.
  
   Patch Failed! 
  Usage Exception: Unable to apply patch!
  ➜  llvm-project git:(arcpatch-D95714) ✗ 

Can you try to reupload the diff, making sure you use full context as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95714/new/

https://reviews.llvm.org/D95714



More information about the cfe-commits mailing list