[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 8 08:11:53 PST 2021


Anastasia marked an inline comment as done.
Anastasia added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1500
         StringRef typeNameRef = typeName;
         // Turn "unsigned type" to "utype"
         if (Ty.isCanonical()) {
----------------
stuart wrote:
> It'd make sense to push this comment down one line, above the `consume_front("unsigned ")` call, as it doesn't apply to the `consume_front("signed ")` call - or reword it so it covers both substitutions.
This has been addressed in the parent review:
https://reviews.llvm.org/D96151


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96161/new/

https://reviews.llvm.org/D96161



More information about the cfe-commits mailing list