[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

[Melanie Blower via Phabricator via cfe-commits]

mibintc added inline comments.


================
Comment at: clang/include/clang/Basic/LangOptions.h:234
+    FEM_Extended,
+    /// Use the default float eval method specified by Target
+    FEM_TargetDefault
----------------
aaron.ballman wrote:
> FYI: it may be somewhat confusing that we have an enumerator with `default` in the name but that enumerator isn't the default.
That's true. I had a heck of a time getting the initialization of the lang option setting correct: the setting should come from the TargetInfo if command line options don't override. That seems simple enough but there's somethng really odd about initialization. Adding the "default target" enumeral allowed me to get it initialized the way I wanted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93769/new/

https://reviews.llvm.org/D93769