[PATCH] D89651: [clang-tidy] Add bugprone-suspicious-memory-comparison check

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.
Herald added a subscriber: nullptr.cpp.

I really love this.
I'm gonna have a look at the blocking patch.



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-suspicious-memory-comparison-32bits.cpp:2
+// RUN: %check_clang_tidy %s bugprone-suspicious-memory-comparison %t \
+// RUN: -- -- -target x86_64-unknown-unknown -m32
+
----------------
gbencze wrote:
> aaron.ballman wrote:
> > Wouldn't picking a 32-bit target suffice instead of `-m32`? e.g., `-target i386-unknown-unknown`
> To be fully honest, I have no idea, I saw some other tests using `-m32` so I decided to copy that. 
Why don't we pick `i386-unknown-linux` instead?
That would limit the scope of this test to Ititanium ABI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89651/new/

https://reviews.llvm.org/D89651