[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 5 07:40:30 PST 2021


aaron.ballman added a comment.

In D96082#2545106 <https://reviews.llvm.org/D96082#2545106>, @Eugene.Zelenko wrote:

> In D96082#2544778 <https://reviews.llvm.org/D96082#2544778>, @steveire wrote:
>
>> @Eugene.Zelenko Why did you remove me from the reviewers list?
>
> Only project's maintainers should be reviewers and approve patch. Sure, nobody prevents you from making comments.

I think that's true for accepting a patch, but not so true for just generic reviewers. For instance, it's common to add reviewers based on who recently modified the code, which often is not a maintainer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96082/new/

https://reviews.llvm.org/D96082



More information about the cfe-commits mailing list