[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 5 05:59:33 PST 2021
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5173
+ if (auto *PLE = llvm::dyn_cast<ParenListExpr>(Base))
+ Base = PLE->getExpr(PLE->getNumExprs() - 1);
+ if (OtherOpBase) {
----------------
mention that why we specialize `ParentListExpr` -- ParenListExprs don't have a predefined type
I think we won't (hopefully) have a 0-children `ParenListExpr`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95935/new/
https://reviews.llvm.org/D95935
More information about the cfe-commits
mailing list