[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

[Valeriy Savchenko via Phabricator via cfe-commits]

vsavchenko added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:166
+  ArrowMap(unsigned Size) : Base(Size, 0) {}
+  unsigned getTotalNumberOfArrows() const { return at(0); }
+};
----------------
ASDenysPetrov wrote:
>   # Whether `size()` is not an aim?
>   # It can fail in case of empty container.
> 
> 
`size()` doesn't mean the same semantically. This structure is at least of size 1.  Please, consider the following code on how this data structure is constructed and used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92928/new/

https://reviews.llvm.org/D92928