[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.

Zequan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 4 16:48:33 PST 2021


zequanwu added inline comments.


================
Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033
+
+    // FIXME: Diagnostics here should point to the end of the initializer
+    // list, not the start.
+    if (!HandleLValueMember(Info, E, Subobject, Field, &Layout))
----------------
rsmith wrote:
> I don't think this FIXME is appropriate in the new context; just remove it. `E` here should already be providing the best location information we have.
Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96092/new/

https://reviews.llvm.org/D96092



More information about the cfe-commits mailing list