[PATCH] D96092: [AST] Update LVal before evaluating lambda decl fields.
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 4 16:36:06 PST 2021
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/AST/ExprConstant.cpp:10032-10033
+
+ // FIXME: Diagnostics here should point to the end of the initializer
+ // list, not the start.
+ if (!HandleLValueMember(Info, E, Subobject, Field, &Layout))
----------------
I don't think this FIXME is appropriate in the new context; just remove it. `E` here should already be providing the best location information we have.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96092/new/
https://reviews.llvm.org/D96092
More information about the cfe-commits
mailing list