[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

[Marek Kurdej via Phabricator via cfe-commits]

curdeius requested changes to this revision.
curdeius added a comment.
This revision now requires changes to proceed.

We're getting close :).



================
Comment at: clang/unittests/Format/FormatTest.cpp:19056
+TEST_F(FormatTest, IndentAccessModifiers) {
+  FormatStyle Style = getLLVMStyle();
+  Style.AllowShortEnumsOnASingleLine = false;
----------------
Please add an assertion that IndentWidth == 2 to make the test easier to understand.


================
Comment at: clang/unittests/Format/FormatTest.cpp:19086
+               Style);
+  verifyFormat("enum class E\n"
+               "{\n"
----------------
Add a comment that `enum`s are not concerned.


================
Comment at: clang/unittests/Format/FormatTest.cpp:19099
+               Style);
+}
 } // namespace
----------------
Add tests with a different IndentWidth.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94661/new/

https://reviews.llvm.org/D94661