[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

[Jessica Clarke via Phabricator via cfe-commits]

jrtc27 added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/vadd.c:22
+{
+    return __builtin_rvv_vadd_vv_i8m1_vl(arg_0, arg_1, arg_2);
+}
----------------
Jim wrote:
> Is it necessary with prefix "__builtin_"?
> Refer to https://github.com/riscv/rvv-intrinsic-doc/blob/master/rvv_intrinsic_funcs_vl/06_vector_integer_arithmetic_functions.md.
rvvintrin.h or whatever it's called will define wrappers. Providing things under a name that's not prefixed by `__` can cause collisions with existing code that's not trying to use these intrinsics, since the names are technically available for it to use, though in practice that seems extremely unlikely for these names. However, using proper `__`-prefixed names is convention, as is using `__builtin_` for anything that's a compiler builtin. This is purely an implementation detail that the user should not need to care about unless they want to not include the header they're meant to include, at which point we provide no guarantees.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93446/new/

https://reviews.llvm.org/D93446