[PATCH] D95714: [clang-tidy] fix modernize-use-nullptr false positive with spaceship operator comparisons

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 16:40:57 PST 2021


njames93 added a comment.

In D95714#2540626 <https://reviews.llvm.org/D95714#2540626>, @poelmanc wrote:

> Thanks for all the great feedback I received here. To give credit where credit's due, this updated revision to UseNullptrCheck.cpp is now actually 100% @steveire's //suggested// code. Even one of the tests cases was his. Whenever it's ready to land I'd appreciate it if someone could push it as I lack llvm-project commit access.

Can I ask if you could tidy the description of this, basically remove all the stuff about hasGrandparent etc, probably best just remove everything after `result = (a1 nullptr a2);` in the desc. It shows in the commit message and its not strictly relevant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95714/new/

https://reviews.llvm.org/D95714



More information about the cfe-commits mailing list