[PATCH] D78979: OpenCL: Include builtin header by default

Wed Feb 3 09:05:11 PST 2021

Anastasia added a comment.

In D78979#2536661 <https://reviews.llvm.org/D78979#2536661>, @arsenm wrote:

> In D78979#2536590 <https://reviews.llvm.org/D78979#2536590>, @Anastasia wrote:
>
>> @arsenm I would like to see if we can finalize this patch soon. Do you think you will have a capacity for this in the next weeks? Otherwise I would be happy to help too.
>
> I don't think I'll have time soon, you can take over
>
>> It looks in a good shape, we just need to decide if we go ahead with the new flag you are adding or reuse `-nostdinc`. Do you have any preference yourself?
>
> Not really sure. No real preference

Thanks, after brainstorming more with other developers I have decided to change the direction slightly that I have explained in the RFC:
https://lists.llvm.org/pipermail/cfe-dev/2021-February/067610.html

I believe this achieves similar goal but it also addresses the long parsing speed that has always been a concern for the default header within the OpenCL community.

Let me know if you have any feedback and either way we decide to go your patch will be a good base point.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78979/new/

https://reviews.llvm.org/D78979