[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 08:24:30 PST 2021


steakhal added a comment.

In D86295#2519851 <https://reviews.llvm.org/D86295#2519851>, @ASDenysPetrov wrote:

> What about this change? Did you make more measurements?

IMO it needs more justification and measurement to land it.

If my measurement was correct then it would decrease the readability of the code without any benefit.
It could be the case due to the allocation strategy & alignment stuff that we don't gain anything by making its layout more compact.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86295/new/

https://reviews.llvm.org/D86295



More information about the cfe-commits mailing list