[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 3 03:20:42 PST 2021


steakhal added a comment.

In D95860#2538802 <https://reviews.llvm.org/D95860#2538802>, @balazske wrote:

> Existing test moved to Frontend, added new test.

Awesome, thanks!

On the functional side of things, I'm not sure if we should skip or not.
But simply skipping those seems like you are treating the symptom, not the cause.
Could you please give a rationale why can't we implement the subsequent logic in a way that it does not require `BeginFileID == EndFileID` to hold?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95860/new/

https://reviews.llvm.org/D95860



More information about the cfe-commits mailing list