[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

Wed Feb 3 00:55:33 PST 2021

balazske added inline comments.

================
Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:29-30
+  <https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_04_03>`_
+  for more information). This is not an extension of the minimal set (``quick_exit``
+  is not included). Default is ``POSIX``.
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > Huh, that's really strange that POSIX leaves `quick_exit` off the list. I'm going to reach out to someone from the Austin Group to see if that's intentional or not.
> I didn't need to reach out to them because I realized the latest POSIX spec is still based on C99 and they've not released the updated POSIX spec yet.
> 
> I think the POSIX functions should be a superset of the C functions.
Do you mean that we should add `quick_exit` to the POSIX set? And have a requirement that minimal set is subset of the POSIX set (if the lists are modified in the future)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90851/new/

https://reviews.llvm.org/D90851