[PATCH] D95822: [FE] Manipulate the first byte of guard variable type in both load and store operation

[Xiangling Liao via Phabricator via cfe-commits]

Xiangling_L marked 2 inline comments as done.
Xiangling_L added inline comments.


================
Comment at: clang/test/CodeGenCXX/global-init.cpp:84
   // CHECK-NEXT: store i32 [[CALL]], i32* @_ZN5test41xE
-  // CHECK-NEXT: store i64 1, i64* @_ZGVN5test41xE
+  // CHECK-NEXT: store i8 1, i8* bitcast (i64* @_ZGVN5test41xE to i8*)
   __attribute__((weak)) int x = foo();
----------------
abhina.sreeskantharajan wrote:
> nit: the lines above omit the end of the line. It's probably better to be consistent
> 
> 
It didn't omit the end of the line. It is because before my patch, there was no casting.


================
Comment at: guard.patch:1
+From 9c7d0afec1e634cdeaf3a2ca4273f5da07f6f946 Mon Sep 17 00:00:00 2001
+From: Xiangling Liao <Xiangling.Liao at ibm.com>
----------------
hubert.reinterpretcast wrote:
> Looks like this file got added by accident.
Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95822/new/

https://reviews.llvm.org/D95822