[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Tue Feb 2 09:15:37 PST 2021

Anastasia added a comment.

In D95778#2536598 <https://reviews.llvm.org/D95778#2536598>, @azabaznov wrote:

> In D95778#2536266 <https://reviews.llvm.org/D95778#2536266>, @Anastasia wrote:
>
>>> LGTM, but perhaps you can add a test that has each keyword disabled?
>>
>> FYI we currently already test that `pipe` and `generic` are valid for OpenCL 2.0 and invalid for OpenCL < 2.0. Or do you mean different kind of tests? In OpenCL 3.0 we will have to set the new `LangOpts` fields based on the values of `OpenCLOptions`  but my guess is that is going to be added in the subsequent patches...
>
> Yes, I believe there are tests already for earlier versions. Should I mark this change as NFC?

I am not sure since we are adding a new `LangOpts` entries it's not entirely NFC. I would just live as is.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95778/new/

https://reviews.llvm.org/D95778