[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

David Spickett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 2 07:34:27 PST 2021


DavidSpickett added reviewers: ostannard, nickdesaulniers.
DavidSpickett added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:753
             : tools::arm::getARMTargetCPU(MCPU, MArch, Triple);
     StringRef Suffix =
       tools::arm::getLLVMArchSuffixForARM(CPU, MArch, Triple);
----------------
Suffix originally set here, from any compiler options.


================
Comment at: clang/lib/Driver/ToolChain.cpp:807
+        // over -Wa,-march. Which matches the compiler behaviour.
+        Suffix = tools::arm::getLLVMArchSuffixForARM(WaMCPU, WaMArch, Triple);
+      }
----------------
Then we override that if we're using the assembler and have -Wa options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95872/new/

https://reviews.llvm.org/D95872



More information about the cfe-commits mailing list