[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

[Andrzej Warzynski via Phabricator via cfe-commits]

awarzynski added a comment.

LGTM!

Thank you for addressing my comments, (`DELETEME` can be fixed when pushing upstream)! From what I can see you've also addressed all of Tim's comments, but could you wait a day or two before merging this? Just in case I missed something, or Tim or somebody else has further comments.



================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:191-192
+  
+  //for (const auto *currentArg : args.filtered(clang::driver::options::OPT_module_dir))  
+  //	    moduleDir = currentArg->getValue();
+  auto moduleDirList = args.getAllArgValues(clang::driver::options::OPT_module_dir);
----------------
DELETEME


================
Comment at: flang/lib/Frontend/FrontendActions.cpp:81-82
   // TODO: These should be specifiable by users. For now just use the defaults.
-  common::LanguageFeatureControl features;
-  Fortran::common::IntrinsicTypeDefaultKinds defaultKinds;
+  // common::LanguageFeatureControl features;
+  // Fortran::common::IntrinsicTypeDefaultKinds defaultKinds;
 
----------------
DELETEME


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95448/new/

https://reviews.llvm.org/D95448