[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 2 04:56:41 PST 2021


Anastasia added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:4308
+      if (T1Quals.hasAddressSpace())
+        Sequence.AddQualificationConversionStep(cv1T1, VK_XValue);
+    } else
----------------
rjmccall wrote:
> Anastasia wrote:
> > rjmccall wrote:
> > > This should only be `VK_XValue` if we're binding a r-value reference, I think.
> > Yes, I think so too.
> Did you mean to fix this to conditionally use VK_LValue?
Sure, I have added it now. Sorry I got confused somehow.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95608/new/

https://reviews.llvm.org/D95608



More information about the cfe-commits mailing list