[PATCH] D95792: [clang][cli] Report result of ParseLangArgs
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 1 20:50:48 PST 2021
dexonsmith added inline comments.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3096
+
+ return Success;
}
----------------
Would this avoid the changes above?
```
return Success && !Diags.hasErrorOccurred();
```
?
Alternatively, might it be cleaner to shove the `Success = false` into a helper lambda or something?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95792/new/
https://reviews.llvm.org/D95792
More information about the cfe-commits
mailing list