[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

Min-Yih Hsu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 1 13:45:48 PST 2021


myhsu added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2101
 
+  static const char *const M68kLibDirs[] = {"/lib"};
+  static const char *const M68kTriples[] = {
----------------
MaskRay wrote:
> The second `const ` is redundant
I don't think so...first, `const char *const` means "a pointer points to const char, and you can't modify this pointer", which make sense in this context. Second, all the surrounding code here are using `const char *const`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88394/new/

https://reviews.llvm.org/D88394



More information about the cfe-commits mailing list